Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-frontend] Add support for non-determinism #1439

Merged
merged 4 commits into from Nov 1, 2023

Conversation

brcfarias
Copy link
Collaborator

This PR:

  • Adds support for nondet_X() functions
  • Adds regression test for non-determinism

Copy link
Contributor

@lucasccordeiro lucasccordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some regression tests with __VERIFIER_nondet_X()? See the definition here: https://sv-comp.sosy-lab.org/2023/rules.php

In particular, try to add some regression tests that fail too.

@lucasccordeiro
Copy link
Contributor

I agree with @fbrausse.

Please check these definitions:

https://github.com/esbmc/esbmc/blob/master/src/clang-c-frontend/clang_c_language.cpp#L431

https://github.com/esbmc/esbmc/blob/master/src/clang-c-frontend/clang_c_language.cpp#L445

We should match them.

Copy link
Contributor

@lucasccordeiro lucasccordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Many thanks for addressing our comments, @brcfarias.

Copy link
Member

@fbrausse fbrausse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nitpick: The test whether the underscore was found could be removed (or become an assertion).

@lucasccordeiro lucasccordeiro merged commit b8df011 into esbmc:master Nov 1, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants