Add OM for pthread_rwlock_rdlock #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasccordeiro
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks for submitting this PR, @Anthonysdu.
Can I also ask you to add a regression test that gives "VERIFICATION FAILED"?
lucasccordeiro
approved these changes
Nov 22, 2023
lucasccordeiro
force-pushed
the
svcomp2024
branch
from
b60d8f1
to
8d11468
Compare
|
Thanks for submitting this PR, @Anthonysdu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression testcase is a reduced version from the incorrect false of
read_write_lock-1-pthreadin SVCOMP.From the pthread document:
The calling thread acquires the write lock if no other thread (reader or writer) holds the read-write lock rwlock.
The calling thread acquires the read lock if a writer does not hold the lock and there are no writers blocked on the lock.