New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for context-aware intervals #1564
Conversation
Master
PR
|
4f8b2ba
to
a425172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, just a few comments.
fa03dab
to
5bb08c1
Compare
5bb08c1
to
63b4912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
745f2a7
to
e9160dc
Compare
@rafaelsamenezes: could you please fix the CI issues here? |
e9160dc
to
2301373
Compare
I changed the failing test case. It seems that the issue is related to using a function pointer. The function ptr is making the abstract interpreter confused about where is the next instruction, resulting in a bottom. I also added the original test case as a knownbug. It seems to be related to having the function ptr call at the end of a block. |
9bb6e60
to
da11943
Compare
da11943
to
ee23982
Compare
This PR enables the abstract domain to have more information about the context where it is invoked. Specifically, this enables:
Disables the interval analysis unit tests due to Goto generation in unit test is not initializing the namespace correctly #1567(solved by PRmigrate_namespace_lookup
now managed by language_uit #1568)