-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not throw on initial LDAP connection failure #9
Merged
dcrissman
merged 10 commits into
esbtools:master
from
alechenninger:do-not-fail-on-connect
Jan 10, 2018
Merged
Do not throw on initial LDAP connection failure #9
dcrissman
merged 10 commits into
esbtools:master
from
alechenninger:do-not-fail-on-connect
Jan 10, 2018
Commits on Jan 6, 2018
-
Do not throw on initial LDAP connection failure
Throwing exceptions during LdapRolesProvider initialization can put applications into a bad state where they do not recover on their own. If LDAP connectivity is unavailable, we can at least let the application keep running and report a more meaningful failure, as opposed to failing to startup completely, unable to report to us anything automatically (and thus requiring looking at logs and such). This can also allow applications to recover on their own without requiring manual intervention.
Configuration menu - View commit details
-
Copy full SHA for af871bd - Browse repository at this point
Copy the full SHA af871bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c20307e - Browse repository at this point
Copy the full SHA c20307eView commit details
Commits on Jan 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fee195e - Browse repository at this point
Copy the full SHA fee195eView commit details -
Revert "Experiment with failFast flag"
This reverts commit fee195e.
Configuration menu - View commit details
-
Copy full SHA for ab7226b - Browse repository at this point
Copy the full SHA ab7226bView commit details -
Add failFast flag to LdapRolesProvider
When true, existing behavior remains. Existing behavior does not allow an instance to be constructed if LDAP connectivity cannot be established. When false, an instance will be created even if the connection fails. getUserRoles will fail until the connection is established. Connection will be retried on the next role lookup after the configured retry interval. Ideally connections would be retried in the background without a lookup being called, but this requires a thread pool, and a thread pool requires managing the life cycle of the roles provider, which might be difficult in the JBoss login module mode. For now this is a simpler alternative that should more or less work the same under traffic.
Configuration menu - View commit details
-
Copy full SHA for c1299c9 - Browse repository at this point
Copy the full SHA c1299c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20de6e1 - Browse repository at this point
Copy the full SHA 20de6e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 445922d - Browse repository at this point
Copy the full SHA 445922dView commit details
Commits on Jan 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7a19359 - Browse repository at this point
Copy the full SHA 7a19359View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dcc0d8 - Browse repository at this point
Copy the full SHA 5dcc0d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8afa24a - Browse repository at this point
Copy the full SHA 8afa24aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.