Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw on initial LDAP connection failure #9

Merged
merged 10 commits into from
Jan 10, 2018

Commits on Jan 6, 2018

  1. Do not throw on initial LDAP connection failure

    Throwing exceptions during LdapRolesProvider initialization can put
    applications into a bad state where they do not recover on their own.
    If LDAP connectivity is unavailable, we can at least let the
    application keep running and report a more meaningful failure, as
    opposed to failing to startup completely, unable to report to us
    anything automatically (and thus requiring looking at logs and such).
    This can also allow applications to recover on their own without
    requiring manual intervention.
    alechenninger committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    af871bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c20307e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2018

  1. Configuration menu
    Copy the full SHA
    fee195e View commit details
    Browse the repository at this point in the history
  2. Revert "Experiment with failFast flag"

    This reverts commit fee195e.
    alechenninger committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    ab7226b View commit details
    Browse the repository at this point in the history
  3. Add failFast flag to LdapRolesProvider

    When true, existing behavior remains. Existing behavior does not allow
    an instance to be constructed if LDAP connectivity cannot be
    established.
    
    When false, an instance will be created even if the connection fails.
    getUserRoles will fail until the connection is established. Connection
    will be retried on the next role lookup after the configured retry
    interval.
    
    Ideally connections would be retried in the background without a lookup
    being called, but this requires a thread pool, and a thread pool
    requires managing the life cycle of the roles provider, which might be
    difficult in the JBoss login module mode. For now this is a simpler
    alternative that should more or less work the same under traffic.
    alechenninger committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    c1299c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20de6e1 View commit details
    Browse the repository at this point in the history
  5. Add missing ;

    alechenninger committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    445922d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Configuration menu
    Copy the full SHA
    7a19359 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5dcc0d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8afa24a View commit details
    Browse the repository at this point in the history