Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Move documentEvent and eventHandlerConfig entities to own maven modules #69

Open
alechenninger opened this issue Sep 19, 2016 · 4 comments

Comments

@alechenninger
Copy link
Contributor

This will make versioning / releasing easier

@derek63
Copy link
Member

derek63 commented Sep 20, 2016

Do you mean a separate GitHub project?

@alechenninger
Copy link
Contributor Author

Separate maven projects, I meant.

On Tue, Sep 20, 2016, 4:31 AM Derek Haynes notifications@github.com wrote:

Do you mean a separate GitHub project?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#69 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVab0MHaelifCMPRPpPBgBz4t8gt_wTks5qr5nXgaJpZM4KAoav
.

@alechenninger alechenninger changed the title Move documentEvent and eventHandlerConfig entities to own projects Move documentEvent and eventHandlerConfig entities to own maven modules Sep 20, 2016
@dcrissman
Copy link
Member

How will it make versioning easier?

@alechenninger
Copy link
Contributor Author

We generate the metadata for these entities using a version in code. This means there are multiple versions to update when you release: the maven project version, and the entity versions.

There is a feature of the metadata generation that can just use the maven pom version if it is added to the jar manifest. If DocumentEventEntity and EventHandlerConfigEntity where their own maven projects, then they could just inherit the maven project version, and then we could remove a manual, error-prone step from our release process (see the README.md).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants