This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Add TransformableFuture.combined #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please do not merge yet. Needs tests. Feel free to comment though. This allows, among other things, for message implementations to share logic with types that produce TransformableFutures, and combine additional work on top of that. Put in other words, it allows any of our Future based APIs to be implemented with any number of Futures internally if they needed (rare but happens), as long as they are returned combined. The semantics of a combined future is [hopefully] what you would expect, and follows Guava's Futures.allAsList. For example, cancel cancels all futures, isCancelled returns true if any of the futures are cancelled, isDone returns true only if all of the futures are done, etc.
| public U get() throws InterruptedException, ExecutionException { | ||
| try { | ||
| return futureTransform.transform(combined.get()); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
This would erroneously catch and rethrow exceptions from combined.get()... need to test and fix
|
I'm going to rework this a bit. Will come back to in later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge yet. Needs tests. Feel free to comment though.
This allows, among other things, for message implementations to share
logic with types that produce TransformableFutures, and combine
additional work on top of that. Put in other words, it allows any of
our Future based APIs to be implemented with any number of Futures
internally if they needed (rare but happens), as long as they are
returned combined.
The semantics of a combined future is [hopefully] what you would expect,
and follows Guava's Futures.allAsList. For example, cancel cancels all
futures, isCancelled returns true if any of the futures are cancelled,
isDone returns true only if all of the futures are done, etc.