Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed list delete slice #1

Merged
merged 4 commits into from
Jun 29, 2019
Merged

Typed list delete slice #1

merged 4 commits into from
Jun 29, 2019

Commits on Jun 27, 2019

  1. implement numba_list_delete_slice

    This implements one of the two remaining C functions:
    numba_list_delete_slice at the C, compiler, and interpreter level. Tests
    are included. The implementation was copied from the relevant parts of
    the cpython source code in `list_ass_subscript` but doesn't exactly
    mirror any specific function. This should also enable acceleration of
    some other bits of the code.
    esc committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    3503f9e View commit details
    Browse the repository at this point in the history
  2. accelerate setitem with slice

    When using setitem with a slice and an item that is smaller than the
    slice, we need to remove items. Until now, this was done with pop, which
    actually incurred a memory move of the tail of the list for every item
    being removed. Now that we can mass delete items in the list with `del`
    and slices, we used that functionality instead.
    esc committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    261dcd1 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2019

  1. Configuration menu
    Copy the full SHA
    a767ce9 View commit details
    Browse the repository at this point in the history
  2. fix refactoring bug

    `_list_get_data` was moved and renamed to `_container_get_data`, this
    bug stems from a failed rebase.
    esc committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    488d6c0 View commit details
    Browse the repository at this point in the history