Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

Update google-fonts-plugin to 3.0.0 #9

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Update google-fonts-plugin to 3.0.0 #9

merged 1 commit into from
Jan 29, 2019

Conversation

SirPole
Copy link
Contributor

@SirPole SirPole commented Jan 27, 2019

Hello! I am developer of google-fonts-plugin.

I made an error in releasing google-fonts-plugin 2.1.0, which is resolved by your plugin and does not work then. I've updated your code to match changes made to my plugin...

Since i don't work with gatsby, I didn't do any tests.

Thanks for understanding, let me know if you need anything else from me! :)

closes #8
closes #6

@kennedyrose kennedyrose merged commit 30c52bc into escaladesports:master Jan 29, 2019
@kennedyrose
Copy link
Contributor

Upon closer inspection, I'm not sure we can use google-fonts-plugin anymore. We need access to the function the saves the CSS files. Is this function still available in 3.0.0?

@SirPole
Copy link
Contributor Author

SirPole commented Jan 31, 2019

I will look into it more during the weekend. My plugin is made for webpack use so I rely on webpack saving these files...

Is there any reason why you can't save the files yourself? What was wrong with the code I proposed?

@kennedyrose
Copy link
Contributor

this.requestFontsCSS isn't available. I can't remember why I was relying on your plugin instead of saving the files out. It's been a while and I unfortunately haven't had the time to work on this plugin in a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants