Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py.typed #5

Closed
ehossack opened this issue May 3, 2020 · 2 comments
Closed

py.typed #5

ehossack opened this issue May 3, 2020 · 2 comments
Assignees
@escaped

Comments

@ehossack
Copy link

ehossack commented May 3, 2020 •
edited
Loading

Is there a reason why this project doesn't have a py.typed file in the module folder?
I'm new to mypy, but it's complaining that there's no typings unless I add that file in the site-packages directory.

I'd submit a PR, but it looks like the build is failing?
@b0g3r
Copy link

b0g3r commented Aug 3, 2020

@escaped, could you please check this issue? Without it, mypy thinks the package doesn't have typing support.

escaped added a commit that referenced this issue Sep 19, 2020
@escaped
fix: add py.typed, #5
9854e33
escaped added a commit that referenced this issue Sep 19, 2020
@escaped
fix: add py.typed, #5
c174fdd
escaped added a commit that referenced this issue Sep 19, 2020
@escaped
fix: add py.typed, #5
036570e
escaped added a commit that referenced this issue Sep 19, 2020
@escaped
fix: add py.typed, #5
73d3d75
@escaped escaped self-assigned this Sep 19, 2020
@escaped
Copy link
Owner

escaped commented Sep 19, 2020 •
edited
Loading

I just released 1.2.0, which includes a py.typed file. :)

@escaped escaped closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@escaped escaped

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@escaped @ehossack @b0g3r