Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: various minor improvements. #13

Closed
wants to merge 1 commit into from
Closed

docs: various minor improvements. #13

wants to merge 1 commit into from

Conversation

ngnpope
Copy link
Contributor

@ngnpope ngnpope commented Apr 6, 2021 •
edited
Loading

Description

Some minor improvements to the documentation.

Checklist

  • Tests covering the new functionality have been added
  • Code builds clean without any errors or warnings
  • Documentation has been updated
  • Changes have been added to the CHANGELOG.md
  • You added yourself to the CONTRIBUTORS.md

@coveralls
Copy link
Collaborator

coveralls commented Apr 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1109051566

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 726608980: 0.0%
Covered Lines: 22
Relevant Lines: 22
💛 - Coveralls

escaped
escaped previously approved these changes Apr 7, 2021
View reviewed changes
Copy link
Owner

@escaped escaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks a lot for all the hard work you've done. But before I merge your PRs, I want to ask if you skipped the CONTRIBUTIONS.md on purpose. You definitely deserve to be mentioned :)

@ngnpope
Copy link
Contributor Author

ngnpope commented Aug 8, 2021

Awesome. Thanks a lot for all the hard work you've done. But before I merge your PRs, I want to ask if you skipped the CONTRIBUTIONS.md on purpose. You definitely deserve to be mentioned :)

Sorry for the delay. I've finally got around to adding myself to CONTRIBUTORS.md.
Let me know if there is anything else I need to do.

@ngnpope ngnpope closed this Jun 3, 2023
@ngnpope ngnpope deleted the patch-2 branch June 3, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escaped escaped escaped left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngnpope @coveralls @escaped