Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonfield instead of jsonfield2 #12

Closed
escaped opened this issue Oct 2, 2020 · 6 comments · Fixed by #15
Closed

Use jsonfield instead of jsonfield2 #12

escaped opened this issue Oct 2, 2020 · 6 comments · Fixed by #15
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers

Comments

@escaped
Copy link
Owner

escaped commented Oct 2, 2020

jsonfield2 is deprecated in favour of jsonfield.

@escaped escaped added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Oct 2, 2020
@MohammedBajuaifer
Copy link

Hi @escaped, Is this issue still open? would like to work on it!

@escaped
Copy link
Owner Author

escaped commented Oct 3, 2020

@MohammedBajuaifer yes, the issue is still and you are free to work on this if you want. If you tackle this issue, could you please have a look at #10 as well? It's basically about updating the documentation to reflect the minimal required Django version, which is enforced by the jsonfield dependency. Thank you :)
If you need any help, pleas let me know.

@MohammedBajuaifer
Copy link

Hi @escaped, thank you! I was looking through the code but I didn't see a place where jsonfield2 being used. Might need a bit of explanation if you don't mind

@escaped
Copy link
Owner Author

escaped commented Oct 3, 2020

Sure, I haven't digged into the code yet again, but if I remember correctly the python package name (basically what you import in your code) is called jsonfield even though the package you are installing is called jsonfield2. So it seems like you "just" need to update the dependency in the pyproject.toml (generated by poetry) and make sure that all tests are passing :)

@escaped
Copy link
Owner Author

escaped commented Oct 23, 2020

HI @MohammedBajuaifer,

just wanted to check in if you are still working on this issue as I would like to include these changes into the next release. I just want to know where things are :)

@escaped
Copy link
Owner Author

escaped commented Oct 31, 2020

Sorry, @MohammedBajuaifer for taking over, but I wanted to get a new release out of the door. Thank you for looking into it though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants