Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow use of remote storage #8

Merged
merged 2 commits into from Oct 8, 2020
Merged

Conversation

jsutlovic
Copy link
Contributor

I was attempting to use exiffield with S3 storage, but the storage backend doesn't support the path operation since the files are not local. I've implemented a workaround that allows exiffield to be used regardless of whether the files are remote.

@coveralls
Copy link

coveralls commented Feb 26, 2020

Pull Request Test Coverage Report for Build 292887961

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 95.556%

Totals Coverage Status
Change from base Build 292883824: -0.5%
Covered Lines: 172
Relevant Lines: 175

💛 - Coveralls

@escaped
Copy link
Owner

escaped commented Mar 5, 2020

Thanks for this great contribution. Will have a proper look at your changes soon, but at a first glance, they look good :)

Copy link
Owner

@escaped escaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution :)

@escaped escaped merged commit 202345b into escaped:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants