Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: django-storages support, fixes #13 #26

Merged
merged 12 commits into from
Jan 2, 2021

Conversation

escaped
Copy link
Owner

@escaped escaped commented Oct 23, 2020

Add support for django-storages. This PR is based on #19 and #14 .

fixes #13

@coveralls
Copy link

coveralls commented Oct 23, 2020

Pull Request Test Coverage Report for Build 364118088

  • 46 of 50 (92.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.04%) to 92.526%

Changes Missing Coverage Covered Lines Changed/Added Lines %
video_encoding/tasks.py 21 25 84.0%
Totals Coverage Status
Change from base Build 364089745: 1.04%
Covered Lines: 316
Relevant Lines: 334

💛 - Coveralls

@lifenautjoe
Copy link
Contributor

Looks good!

@escaped
Copy link
Owner Author

escaped commented Oct 29, 2020

Yeah, it does. What I like to add before I merge this PR is to add a test. Unfortunately, I haven't found the time to write one yet.

@escaped escaped force-pushed the feat/django-storages-support branch 3 times, most recently from aa63360 to 98b72f0 Compare November 13, 2020 06:58
@escaped escaped mentioned this pull request Nov 13, 2020
@escaped
Copy link
Owner Author

escaped commented Nov 13, 2020

@lifenautjoe @bashu I just finished the work on this PR. Would be great if you guys could check it out and tell if you find any issues. 🙏
I added a test (using a FakeRemoteStorage) and did some refactoring as well, to simplify the codebase. There is still quite some stuff which could be improved, but that is definitely out of scope 🙄 Anyway, thanks again for your efforts.

@lifenautjoe
Copy link
Contributor

Hi Alexander! I've been following up the PR :-). Will run my integration tests with this branch and will come back to you.

Thanks for the great work!

@escaped
Copy link
Owner Author

escaped commented Dec 21, 2020

Hey @lifenautjoe, just wanted to check in whether you already had a chance to test this PR. No sweat if you haven't. I might be able to run a proper test against some remote storage over the holiday season.

@escaped
Copy link
Owner Author

escaped commented Jan 2, 2021

I just tested this implementation using django-storage and dropbox as a backend. Worked flawless :)

@escaped escaped merged commit 7109135 into master Jan 2, 2021
@escaped escaped deleted the feat/django-storages-support branch January 2, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure it works with django-storages...
3 participants