-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: django-storages support, fixes #13 #26
Conversation
Pull Request Test Coverage Report for Build 364118088
💛 - Coveralls |
Looks good! |
Yeah, it does. What I like to add before I merge this PR is to add a test. Unfortunately, I haven't found the time to write one yet. |
aa63360
to
98b72f0
Compare
@lifenautjoe @bashu I just finished the work on this PR. Would be great if you guys could check it out and tell if you find any issues. 🙏 |
Hi Alexander! I've been following up the PR :-). Will run my integration tests with this branch and will come back to you. Thanks for the great work! |
b5e2b07
to
1af89ba
Compare
Hey @lifenautjoe, just wanted to check in whether you already had a chance to test this PR. No sweat if you haven't. I might be able to run a proper test against some remote storage over the holiday season. |
I just tested this implementation using |
Add support for
django-storages
. This PR is based on #19 and #14 .fixes #13