Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Project.toml UUID #42

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Fix Project.toml UUID #42

merged 1 commit into from
Jan 6, 2019

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Jan 6, 2019

It looks like the UUID in Project.toml is different from the one in the registry: https://github.com/JuliaRegistries/General/blob/master/S/SIMD/Package.toml

This PR make ]test SIMD works after ]dev SIMD, although I remember it worked before... Maybe something changed in Pkg.jl? Anyway, I think it's better to match the UUID.

@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #42 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   81.78%   82.85%   +1.07%     
==========================================
  Files           1        1              
  Lines         719      729      +10     
==========================================
+ Hits          588      604      +16     
+ Misses        131      125       -6
Impacted Files Coverage Δ
src/SIMD.jl 82.85% <0%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad5d1e...a5d8569. Read the comment docs.

@eschnett
Copy link
Owner

eschnett commented Jan 6, 2019

I don't understand what is happening here. Changing the UUID seems like a drastic step that might have negative consequences as well. Can you inquire on the mailing list why this might have happened, and what the recommended resolution is?

@tkf
Copy link
Contributor Author

tkf commented Jan 6, 2019

How did you create Project.toml? If you used Pkg.generate()/]generate, it explains why it has a different UUID since Pkg.generate generates a random UUID whereas packages that to be registered have to use Pkg.METADATA_compatible_uuid which gives us

julia> Pkg.METADATA_compatible_uuid("SIMD")
UUID("fdea26ae-647d-5447-a871-4b548cad5224")

(as in https://github.com/JuliaRegistries/General/blob/master/S/SIMD/Package.toml). Also, it looks like UUID in Project.toml is ignored during registration (and also during tagging?) JuliaRegistries/General#22 so maybe that's why there was no error in the latest releases.

@fredrikekre
Copy link

I don't understand what is happening here.

It was wrong from the start (c852caf).

what the recommended resolution is?

This PR.

@eschnett eschnett merged commit b3ab9ef into eschnett:master Jan 6, 2019
@tkf
Copy link
Contributor Author

tkf commented Jan 6, 2019

@fredrikekre Thanks for confirming that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants