Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to sub-messages #4

Closed
domenic opened this issue Feb 19, 2013 · 1 comment
Closed

Links to sub-messages #4

domenic opened this issue Feb 19, 2013 · 1 comment

Comments

@domenic
Copy link

domenic commented Feb 19, 2013

E.g. if I wanted to link to a reply halfway down the page, it needs an ID. The "content-x" IDs sadly don't work, because (a) they link to the content, not the header, so you don't know who the message is from; (b) the dynamically-generated nature of the page means they don't work when going there from external sources.

One solution might be to look at the hash on startup, and delay scrolling there (using element.scrollIntoView) until the markup generation is done.

@ForbesLindesay
Copy link
Member

That solution would be fine with me. If you make a pull request I'll accept it, or I'll do it when I get time.

alejandro pushed a commit to alejandro/esdiscuss.org that referenced this issue Feb 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants