Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esdoc-ecmascript-proposal-plugin] Optional catch binding not supported #86

Open
cedx opened this issue Apr 27, 2019 · 4 comments
Open

Comments

@cedx
Copy link

cedx commented Apr 27, 2019

"esdoc": "^1.1.0",
"esdoc-ecmascript-proposal-plugin": "^1.0.0",
"esdoc-standard-plugin": "^1.0.0"

I get the following error :
warning: could not parse the following code

When the parser encounter an optional catch binding:

try {
  const fileStats = await promises.stat(file);
  if (!fileStats.isFile()) return false;
  return Finder.isWindows ? this._checkFileExtension(file) : this._checkFilePermissions(fileStats);
}

catch { // <= optional catch binding
  return false;
}

In the generated documentation, the whole file is skipped.

@cedx
Copy link
Author

cedx commented Apr 28, 2020

I close this issue because we have just exceeded one year of seniority 😴

@cedx cedx closed this as completed Apr 28, 2020
@fab1o
Copy link

fab1o commented Nov 2, 2021

@cedx I'm having this issue as well, it's failing my build process. Can we reopen this and get this fixed please?

@cedx
Copy link
Author

cedx commented Nov 2, 2021

@fab1o Sure... but I think @h13i32maru has moved on: he doesn't seem to maintain this project anymore.
We can't blame him: I have myself moved on (I replaced JavaScript by the Haxe language on all my projects 😄).

@cedx cedx reopened this Nov 2, 2021
@fab1o
Copy link

fab1o commented Nov 2, 2021

@cedx Thanks! I started it but I think I'm missing something cos npm test is not passing, could you take a look? #101

@h13i32maru I'm not sure I understand how the mechanics are, how does it include/use the babel plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants