Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] fix lintian errors on pod2man #2

Closed
gregoa opened this issue Aug 13, 2015 · 4 comments
Closed

[PATCH] fix lintian errors on pod2man #2

gregoa opened this issue Aug 13, 2015 · 4 comments

Comments

@gregoa
Copy link

gregoa commented Aug 13, 2015

In Debian we are currently applying the following patch to
p5-Kwalify.
We thought you might be interested in it too.

Subject: fix lintian errors on pod2man
Origin: vendor
From: Victor Seva <linuxmaniac@torreviejawireless.org>
Last-Update: 2015-08-13

The patch is tracked in our Git repository at
https://anonscm.debian.org/cgit/pkg-perl/packages/pkwalify.git/plain/debian/patches/fix_manpages.patch

Thanks for considering,
gregor herrmann,
Debian Perl Group

eserte added a commit that referenced this issue Aug 13, 2015
@eserte
Copy link
Owner

eserte commented Aug 13, 2015

Thanks, but I don't understand some things in the proposed patch:

  • the added =encoding directive in Kwalify.pm seems unnecessary to me --- there's no literal latin2 text in this Pod, just an escaped unicode codepoint which just happens to appear in the latin2 charset, but encoding directives are not necessary for escaped characters
  • why the moved =encoding directives in Schema/Kwalify.pm and pkwalify? perlpodspec says that this directive "should occur early in the document". At least it makes the diff unnecessary big

@gregoa
Copy link
Author

gregoa commented Aug 14, 2015

On Thu, 13 Aug 2015 13:30:28 -0700, Slaven Rezić wrote:

Hi,

and thanks for your quick reply.
I've forwarded your question to the original author of the patch as
well who might be better suited to answer.

Cheers,
gregor

.''. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ . ' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe -

@linuxmaniac
Copy link

the added =encoding directive in Kwalify.pm seems unnecessary to me
why the moved =encoding directives in Schema/Kwalify.pm and pkwalify?

You're quite right, my rockie mistake. Patch updated.

@eserte
Copy link
Owner

eserte commented Aug 14, 2015

OK. I have a slightly different patch already committed.

@eserte eserte closed this as completed Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants