New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add missing 'use warnings;' as reported by CPANTS. #4

Merged
merged 2 commits into from Jun 7, 2016

Conversation

Projects
None yet
3 participants
@manwar
Contributor

manwar commented Jun 6, 2016

Hi @eserte

Please review the above changes as a part of PRC 2016 task.

Many Thanks.
Best Regards,
Mohammad S Anwar

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 6, 2016

Coverage Status

Coverage increased (+0.1%) to 85.586% when pulling 68dd856 on Manwar:fix-cpants-reported-issue into a071837 on eserte:master.

coveralls commented Jun 6, 2016

Coverage Status

Coverage increased (+0.1%) to 85.586% when pulling 68dd856 on Manwar:fix-cpants-reported-issue into a071837 on eserte:master.

@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Jun 7, 2016

Owner

Hi Mohammad,

thanks for the pull request. With the addition of "use warnings", the pre-5.6 BEGIN block in Kwalify.pm is not needed anymore and may be removed. Can you add this to the PR? Anyway, as warnings::compat is a prereq for perl5.005 and earlier, this BEGIN block was not necessary at all.

Regards,
Slaven

Owner

eserte commented Jun 7, 2016

Hi Mohammad,

thanks for the pull request. With the addition of "use warnings", the pre-5.6 BEGIN block in Kwalify.pm is not needed anymore and may be removed. Can you add this to the PR? Anyway, as warnings::compat is a prereq for perl5.005 and earlier, this BEGIN block was not necessary at all.

Regards,
Slaven

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Jun 7, 2016

Contributor

Hi Slaven,

Thanks for the suggestion. Pushed the changes as per your suggestion.

Best Regards,
Mohammad S Anwar

Contributor

manwar commented Jun 7, 2016

Hi Slaven,

Thanks for the suggestion. Pushed the changes as per your suggestion.

Best Regards,
Mohammad S Anwar

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 7, 2016

Coverage Status

Coverage increased (+1.2%) to 86.697% when pulling 2525df8 on Manwar:fix-cpants-reported-issue into a071837 on eserte:master.

coveralls commented Jun 7, 2016

Coverage Status

Coverage increased (+1.2%) to 86.697% when pulling 2525df8 on Manwar:fix-cpants-reported-issue into a071837 on eserte:master.

@eserte eserte merged commit ca73bd2 into eserte:master Jun 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eserte

This comment has been minimized.

Show comment
Hide comment
@eserte

eserte Jun 7, 2016

Owner

Thanks!

Owner

eserte commented Jun 7, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment