- Add missing 'use warnings;' as reported by CPANTS. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mohammad, thanks for the pull request. With the addition of "use warnings", the pre-5.6 BEGIN block in Kwalify.pm is not needed anymore and may be removed. Can you add this to the PR? Anyway, as warnings::compat is a prereq for perl5.005 and earlier, this BEGIN block was not necessary at all. Regards, |
|
Hi Slaven, Thanks for the suggestion. Pushed the changes as per your suggestion. Best Regards, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eserte
Please review the above changes as a part of PRC 2016 task.
Many Thanks.
Best Regards,
Mohammad S Anwar