Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1.0 container update #608

Merged
merged 16 commits into from
Feb 22, 2024
Merged

V1.1.0 container update #608

merged 16 commits into from
Feb 22, 2024

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Feb 16, 2024

Description

This PR will be a general update for containers.

  • Add runtime configuration for frontend
  • Automate container build/release to ghcr.io

Todo before merge:

  • Add test
  • Fix container workflow trigger
  • Revert 36b779c

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jasonb5 jasonb5 changed the base branch from master to v1.1.0 February 16, 2024 18:29
@jasonb5
Copy link
Collaborator Author

jasonb5 commented Feb 16, 2024

Here's a status of all commits made in #594.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9d3888) 100.00% compared to head (8ae5825) 98.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##            v1.1.0     #608      +/-   ##
===========================================
- Coverage   100.00%   98.54%   -1.46%     
===========================================
  Files           30       76      +46     
  Lines          910     2751    +1841     
  Branches         0      420     +420     
===========================================
+ Hits           910     2711    +1801     
- Misses           0       40      +40     
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend 97.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashakames
Copy link
Collaborator

Thank you @jasonb5 @downiec could review just to be sure, and I'll do a production regression test merge on our green-net server. Have you run this branch on Nimbus yet?

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Feb 16, 2024

I haven't yet, it's next up.

TODO

  • Build and test on Nimbus
  • Correct workflow triggers; should always build for PR's but only push when a new tag is created

@jasonb5 jasonb5 mentioned this pull request Feb 16, 2024
12 tasks
@sashakames
Copy link
Collaborator

This failed test might be an intermittent issue

@downiec
Copy link
Collaborator

downiec commented Feb 16, 2024

This failed test might be an intermittent issue

Still trying to figure out why this fails on github but passes locally...

Copy link
Collaborator

@downiec downiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried testing this locally and looks like everything works fine. I think we can merge with v1.1.0 and then I'll figure out why the globus test is failing

@sashakames sashakames merged commit 6aadecb into v1.1.0 Feb 22, 2024
6 checks passed
@jasonb5 jasonb5 deleted the v1.1.0_container_update branch February 22, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants