Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created an endpoint selection modal popup for users to save, add improvements on endpoint selection #630

Open
wants to merge 29 commits into
base: globus-update-scopes
Choose a base branch
from

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Apr 4, 2024

Description

The endpoints that are saved will populate the drop-down endpoint selection so that users can choose the endpoint to transfer to. Created the variables to save the endpoint list in the session storage the same as other Globus download data is saved.

Fixes # (issue)

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sashakames and others added 9 commits March 27, 2024 10:26
…remove preferred endpoints. The endpoints that are saved will populate the drop-down endpoint selection so that users can choose the endpoint to transfer to. Created the variables to save the endpoint list in the session storage the same as other globus donwload data is saved.
@downiec downiec self-assigned this Apr 4, 2024
downiec and others added 20 commits April 4, 2024 14:03
* Fixes creating files templated/generated by entrypoint
* Fixes HTML_PATH
…es. Removed version from docker compose files.
… functions that may have been brought in by recent merge.
…rch popup. This will be addressed more elegantly in the future.
…plate. Also updated the add search query api call to include X-CSRFToken, to mimic what is used in the add cart item api call. Hopefully this will fix the issue with adding saved searches when logged in, need to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants