Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trial selection with arrays #180

Closed
tensionhead opened this issue Jan 6, 2022 · 0 comments
Closed

trial selection with arrays #180

tensionhead opened this issue Jan 6, 2022 · 0 comments
Assignees
Labels
Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the

Comments

@tensionhead
Copy link
Contributor

A trial selection with an integer array select= {'trials' : np.array([1,2,3])} fails and throws an AttributeError.

@tensionhead tensionhead added the Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the label Jan 6, 2022
@pantaray pantaray added this to In progress in Continuous Release Updates Feb 28, 2022
pantaray added a commit that referenced this issue Mar 1, 2022
- use select keys that are identically named as their corresponding class
  attributes (e.g., ``select={'channel':...}``)
- allow trial selections using NumPy arrays (closes #180)
- consistently support scalar selectors (e.g., ``select={'channel':'channel01'}``)
  (addresses #39)
- check anonymous keywords of `selectdata` to filter for typos like ``trails=[0,1]``
  (closes #223)
- todo: modify tests and include new tests for introduced functionality

 On branch fix_selectcsdata
 Changes to be committed:
	modified:   syncopy/datatype/base_data.py
	modified:   syncopy/datatype/methods/selectdata.py
	modified:   syncopy/shared/computational_routine.py
	modified:   syncopy/shared/kwarg_decorators.py
	modified:   syncopy/shared/tools.py
	modified:   syncopy/tests/local_spy.py
	modified:   syncopy/tests/test_computationalroutine.py
	modified:   syncopy/tests/test_connectivity.py
	modified:   syncopy/tests/test_continuousdata.py
	modified:   syncopy/tests/test_discretedata.py
	modified:   syncopy/tests/test_selectdata.py
@pantaray pantaray closed this as completed Mar 4, 2022
Continuous Release Updates automation moved this from In progress to Closed Mar 4, 2022
pantaray added a commit that referenced this issue Mar 4, 2022
- included tests for scalar selections (closes #39)
- included tests for trial selections via NumPy arrays (closes #180)
- included tests for proper parsing of selection keywords (closes #223)

 On branch fix_selectcsdata
 Changes to be committed:
	modified:   syncopy/tests/test_continuousdata.py
	modified:   syncopy/tests/test_selectdata.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that is serious but does not break (parts of) the package. However, it clearly impedes the
Projects
No open projects
Development

No branches or pull requests

2 participants