Clarify Auth header requirements #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth header does not need to be URL safe, but does need to include padding
GoldenGnu
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing with the 4 dev applications I have, and confirmed that none of them resulted in
/or+being included in the resulting base64 string. This is probably due to the limited character set of the client id/secret. If someone's credentials does include those, we should determine if it actually matters if its URL safe or not. As Basic Auth RFC points to the non URL safe Base64 RFC. So I'm skeptical if URL safe was the right thing to suggest in the first place.I also clarified, and added an example, that padding on the base64 string is required. The example could be used to give a point of reference for someone to validate their implementation against.
Somewhat alievates ccpgames/sso-issues#75, but it should still ultimately
403if invalid credentials are provided.