Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure_id to the response of /universe/structures/{structure_id}/ #1343

Closed
4 of 8 tasks
ebeisecker opened this issue Jan 23, 2023 · 1 comment
Closed
4 of 8 tasks
Labels
duplicate Issue is similar to an already existing one. esi-universe inconsistency

Comments

@ebeisecker
Copy link

ebeisecker commented Jan 23, 2023

Feature Request

It would be nice if the response from /universe/structures/{structure_id}/ would return the ID of the structure being queries structure_id.

Use case

When writing an application that deserializes the response of /universe/structures/{structure_id}/ into an object it's messy to have to manually "add" the structure_id to object instead of it being populated as part of the deserialization process

Authentication

This would be modifying the existing route that uses scope esi-universe.read_structures.v1

Example return

Propose what an example return might look like. E.g.:

GET /universe/structures/123456789/?datasource=tranquility

{
  "name": "My Structure",
  "owner_id": 1234567,
  "position": {
    "x": -112983717892,
    "y": 123897598718,
    "z": 105182759178
  },
  "solar_system_id": 3456768,
  "type_id": 345678,
  "structure_id": 123456789
}

Checklist

Check all boxes that apply to this issue:

  • Feature request description is provided
  • Use case exists
  • Feature requires a new route
  • Feature adds data to existing route
  • Feature requires new auth scope
  • Feature can reuse existing scope
  • Feature does not require auth
  • Meta feature, applies to all routes
@Blacksmoke16 Blacksmoke16 added duplicate Issue is similar to an already existing one. esi-universe inconsistency labels Jan 23, 2023
@Blacksmoke16
Copy link
Member

Duplicate of #1122

@Blacksmoke16 Blacksmoke16 marked this as a duplicate of #1122 Jan 23, 2023
@Blacksmoke16 Blacksmoke16 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue is similar to an already existing one. esi-universe inconsistency
Projects
None yet
Development

No branches or pull requests

2 participants