You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #273 but provides more info, and additional endpoints.
In some frameworks it is less efficient to try to match results to requests than it is to simply have the id in the response. This also greatly improves readability of code, makes threading easier, and assists in creating foreign-key relations on the receiving end. There are three /universe/ endpoints that do NOT return their ID in the response.
Inconsistency
Most Universe endpoints contain their own id:
/universe/categories/{category_id} -- contains category_id in response
/universe/constellations/{constellation_id} -- contains constellation_id in response
/universe/graphics/{graphic_id) -- contains graphic_id in response
/universe/groups/{group_id} -- contains group_id in response
/universe/moons/{moon_id} -- contains moon_id in response
/universe/planets/{planet_id} -- contains planet_id in response
/universe/regions/{region_id} -- contains region_id in response
/universe/stargates/{starget_id} -- contains stargate_id in response
/universe/stations/{station_id} -- contains station_id in response
/universe/systems/{system_id} -- contains system_id in response
/universe/types/{type_id} -- contains type_id in response.
These detail end points do NOT:
/universe/asteroid_belts/{asteroid_belt_id} -- missing asteroid_belt_id from response
/universe/stars/{star_id} -- missing star_id from response
/universe/structures/{structure_id} -- missing structure_id from response
Routes
GET /v1/universe/asteroid_belts/{asteroid_belt_id}/
GET /v1/universe/stars/{star_id}/
GET /v2/universe/structures/{structure_id}/
Resolution
Add noted id's to the three endpoints in Universe that are missing them.
Related to #273 but provides more info, and additional endpoints.
In some frameworks it is less efficient to try to match results to requests than it is to simply have the id in the response. This also greatly improves readability of code, makes threading easier, and assists in creating foreign-key relations on the receiving end. There are three /universe/ endpoints that do NOT return their ID in the response.
Inconsistency
Most Universe endpoints contain their own id:
category_id
in responseconstellation_id
in responsegraphic_id
in responsegroup_id
in responsemoon_id
in responseplanet_id
in responseregion_id
in responsestargate_id
in responsestation_id
in responsesystem_id
in responsetype_id
in response.These detail end points do NOT:
asteroid_belt_id
from responsestar_id
from responsestructure_id
from responseRoutes
GET /v1/universe/asteroid_belts/{asteroid_belt_id}/
GET /v1/universe/stars/{star_id}/
GET /v2/universe/structures/{structure_id}/
Resolution
Add noted id's to the three endpoints in Universe that are missing them.
Checklist
The text was updated successfully, but these errors were encountered: