Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk CharacterName->CharacterID endpoint #27

Closed
a-tal opened this issue Nov 9, 2016 · 6 comments
Closed

Bulk CharacterName->CharacterID endpoint #27

a-tal opened this issue Nov 9, 2016 · 6 comments

Comments

@a-tal
Copy link
Contributor

a-tal commented Nov 9, 2016

https://trello.com/c/f8h8Aw6D/18-bulk-charactername-characterid-endpoint

@gitAskur
Copy link
Contributor

gitAskur commented Feb 1, 2017

Whoops, should have closed this down a long time ago (or assign it somewhere else).

Action get_character_names-v1 was created some time ago, and fixed to prime things properly some time ago as well, and that's what is sitting out on TQ right now.

@DaneelTrevize
Copy link

DaneelTrevize commented Mar 6, 2017

The original Trello link seems invalid (edit: or is private to CCP), but I fail to see how get_character_names is an implementation of a name -> ID lookup.

ESI says: "Implementation Notes: Resolve a set of character IDs to character names".

Similarly post_universe_names only does the reverse too. Neither offer a bulk replacement for the XML API's /eve/CharacterID.xml.aspx which takes "Comma-separated list of character names to query." and returns IDs.

All is as per a discussion from ~ the start of Feb, when this issue was (mistakenly?) deemed Done soon after.
https://www.reddit.com/r/evetech/comments/5pik01/character_name_api_lookups_in_2017/

@gitAskur
Copy link
Contributor

gitAskur commented Mar 7, 2017

Yup, that's totally me just reading things wrong, turning them around in my head, and closing this as a characterID > characterName request. My bad!

Reopening, pending internal discussions.

@gitAskur gitAskur reopened this Mar 7, 2017
@gitAskur gitAskur added New and removed Done labels Mar 7, 2017
@gitAskur gitAskur added In Progress and removed New labels May 2, 2017
@gitAskur
Copy link
Contributor

gitAskur commented May 2, 2017

After having looked at this, the potential solutions, spoken with people about their use cases, with @tsuthers-ccpgames about our options and educated a handful of my coworkers about the benefits of democratisizing our markets and economies, much like we democratisized our body politics; we have decided to hold off on ESI implementation until we have launched the new elastic search driven search for EVE.

Reimplementing this as a Monolith side action just as an intermediate step is way too much work that will be undone in a month or three.

As such I am removing myself from this and setting it back to New.

@gitAskur gitAskur added New and removed In Progress labels May 2, 2017
@gitAskur gitAskur removed their assignment May 2, 2017
@aquarhead aquarhead added Backlog and removed New labels Jun 9, 2017
@aquarhead aquarhead added in-backlog Issue has been accepted, but is considered low priority. and removed Backlog labels Aug 29, 2017
@ccp-zoetrope ccp-zoetrope self-assigned this Nov 27, 2017
@ccp-zoetrope ccp-zoetrope added in-progress Issue is being worked on by a developer. and removed in-backlog Issue has been accepted, but is considered low priority. labels Nov 27, 2017
@CarbonAlabel
Copy link
Member

A quick reminder in case it slipped someone's mind: the /eve/CharacterID.xml.aspx endpoint this is supposed to replace isn't only used to translate character names to their IDs; it does the same for corporations, alliances, factions, systems, stations, celestials and just about everything else which has a name.

@ccp-zoetrope
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants