Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/universe/post_universe_ids returning unrelated Corporations when submitting Character names to resolve #806

Closed
DaneelTrevize opened this issue Mar 19, 2018 · 15 comments
Assignees

Comments

@DaneelTrevize
Copy link

Bug

Request

curl -X POST "https://esi.tech.ccp.is/latest/universe/ids/" -H "accept: application/json" -H "Content-Type: application/json" -d "[ \"afk x\"]"

Response

{ "corporations": [ { "id": 98364532, "name": "HaHa Hab dich" } ] }

Expected

{ "characters": [ { "id": 95934406, "name": "afk x" } ] }

They exist, as per https://esi.tech.ccp.is/latest/search/?categories=character&search=afk%20x&strict=true, https://zkillboard.com/character/95934406/ and Jita local in-game very recently.

@a-tal
Copy link
Contributor

a-tal commented Mar 19, 2018

that's not an unrelated corporation, that corporation's ticker is 'afk x'. it should be returning both categories though...

we should maybe remove this endpoint anyway though. @ccp-zoetrope thoughts?

@DaneelTrevize for an immediate workaround, use the /search/ endpoint instead:

curl -X GET "https://esi.tech.ccp.is/latest/search/?categories=character,corporation&search=afk%20x&strict=true" -H "accept: application/json"

@DaneelTrevize
Copy link
Author

DaneelTrevize commented Mar 19, 2018

Gah, this endpoint was added to finally resolve issue #27 which is most needed for the bulk resolving of Local Scan parsers.
Thanks for the quick response though.

@ccp-zoetrope
Copy link
Contributor

Seems this is cache based again because it works correctly the first time you do it but if it pulls from the cache it will only return "HaHa Hab dich".

@a-tal why should we remove this endpoint?

@ccp-zoetrope ccp-zoetrope self-assigned this Mar 20, 2018
@DaneelTrevize
Copy link
Author

Related caching issues: #811

@Shegox
Copy link

Shegox commented Apr 13, 2018

got the same problem, I found out that this happens with 5 char long character (["Latch", "Hungo", "Dalic"]) names in my case.
The following is what I saw:
Request:

curl -i --compressed -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '["Latch", "Hungo", "Dalic"]' 'https://esi.tech.ccp.is/latest/universe/ids/?datasource=tranquility&language=en-us'

Response:

{
  "corporations": [
    {
      "id": 98022707,
      "name": "Latchkey Kids"
    },
    {
      "id": 98311751,
      "name": "Im Hungover"
    },
    {
      "id": 98546273,
      "name": "Dallocort Corporation"
    }
  ]
}

Expected 3 Character Ids, is there a patch planned or some workaround?

Edit: I'm doing a single search request for every name now, this gives the expected results, but takes quite longer.

@iay
Copy link

iay commented Apr 13, 2018

Observation: those five-character strings are the corporation tickers for the corporations in question.

@Shegox
Copy link

Shegox commented Apr 13, 2018

that makes sense @iay , would be cool in that case to allow a flag to filter for character, or return both values under the characters & corperations names.

@DaneelTrevize
Copy link
Author

Read up, the first reply was CCP confirming it's tickers-related and that "it should be returning both categories though".

@ccp-zoetrope
Copy link
Contributor

@Shegox the real problem here is that both those corporations and the characters should be showing up, but due to a caching problem they are not. A fix is in the works but fanfest craziness has pushed this back a bit.

@Shegox
Copy link

Shegox commented Jun 19, 2018

Any update on this issues? I just tested and got on the first try both (chars and corp) returned, afterwards only the corps.
As I'm looking to switch from the /search endpoint for mass characterId lookup and reduce the request amount.
@ccp-zoetrope @a-tal

@jowrjowr
Copy link

jowrjowr commented Jul 29, 2018

running into an instance of this on my side

character: bgtop (92482138)
corp: bgtop (98054246)

what's interesting is the corp isn't actually named bgtop but that is rather their ticker

this is what ESI returns:

$ curl -d '["BGTOP"]' -X POST "https://esi.evetech.net/latest/universe/ids/"
{"corporations":[{"id":98054246,"name":"The Circus Corp"}]}

returning everything in the case of degeneracies would be the ideal solution here

the mitigation right now is the search endpoint but that doesn't accept bulk requests

@WhiteRusssian
Copy link

@ccp-zoetrope , any idea when we should expect this issue to be fixed? Is this a matter of weeks or months?

@Aidansavage
Copy link

Soon(tm)

@ccp-zoetrope ccp-zoetrope added the in-staging A solution for this issue is ready, and is waiting to be deployed. label Aug 3, 2018
@ccp-zoetrope
Copy link
Contributor

@WhiteRusssian a fix for this is slated for release so this will be coming out soon

@a-tal a-tal closed this as completed Aug 3, 2018
@a-tal a-tal removed the in-staging A solution for this issue is ready, and is waiting to be deployed. label Aug 3, 2018
@a-tal
Copy link
Contributor

a-tal commented Aug 3, 2018

this fix was pushed to prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants