Support for CVC concatenated signatures #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Rainer, Thanks for your contribution. I did some more investigations on this case and I didn't find better solution than your. Kind regards, Pierrick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to CVC concatenated signatures (in addition to ASN.1 encoded signatures).
Because CVC does not follow a structure like ASN.1, then I couldn't find a way to determine if a signature is definitely CVC or not. CVC signature bytes are simply concatenated. It is possible to check if the signature is ASN.1 encoded.
The fix origins from https://esig-dss.atlassian.net/browse/DSS-801
Estonian Mobile ID ECDSA signatures are encoded in CVC.
Regards