Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in unit tests #191

Closed
fxbonnet opened this issue Apr 27, 2018 · 1 comment
Closed

Race condition in unit tests #191

fxbonnet opened this issue Apr 27, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@fxbonnet
Copy link
Member

EsiTest.testParallelPerformance fails randomly as MockConnectionManager is not thread safe

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.882 sec <<< FAILURE! - in org.esigate.extension.parallelesi.EsiTest
testParallelPerformance(org.esigate.extension.parallelesi.EsiTest) Time elapsed: 0.88 sec <<< FAILURE!
junit.framework.ComparisonFailure: null expected:<...Fragment 4 Fragment [2]> but was:<...Fragment 4 Fragment [1 Fragment 3 Fragment 4]>
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at org.esigate.extension.parallelesi.EsiTest.testParallelPerformance(EsiTest.java:343)

@fxbonnet fxbonnet added the bug label Apr 27, 2018
@fxbonnet fxbonnet self-assigned this Apr 27, 2018
fxbonnet added a commit to fxbonnet/esigate that referenced this issue Apr 30, 2018
@fxbonnet fxbonnet added this to the 5.3 milestone Apr 30, 2018
@nricheton
Copy link
Member

fix was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants