Good enough for 0.1

esigler · Feb 14, 2016 · 4c9c2b6 · 4c9c2b6
1 parent 0669430
commit 4c9c2b6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 20 deletions.
diff --git a/lib/lita/handlers/hush.rb b/lib/lita/handlers/hush.rb
@@ -13,7 +13,7 @@ class Hush < Handler
         :voice,
         command: true,
         help: {
-          t('help.add.syntax') => t('help.add.desc')
+          t('help.voice.syntax') => t('help.voice.desc')
         }
       )
 
@@ -49,26 +49,23 @@ def ambient(response)
       def moderate(response)
         src = response.message.source
 
-        if response.match_data['toggle'] == 'on'
-          moderate_room(src.room)
-          give_voice(src.room, src.user)
-          action = 'moderated'
-        else
-          unmoderate_room(src.room)
-          action = 'unmoderated'
-        end
+        action = if response.match_data['toggle'] == 'on'
+                   moderate_room(src.room)
+                   give_voice(src.room, src.user)
+                   'moderated'
+                 else
+                   unmoderate_room(src.room)
+                   'unmoderated'
+                 end
 
         response.reply(t('moderation.complete', action: action))
       end
 
       def status(response)
-        msg = if room_moderated?(response.message.source.room)
-                t('status.moderated')
-              else
-                t('status.unmoderated')
-              end
+        src = response.message.source
+        state = room_moderated?(src.room) ? 'moderated' : 'unmoderated'
 
-        response.reply(msg)
+        response.reply(t('status.overview', state: state))
       end
 
       def voice(response)
@@ -109,10 +106,10 @@ def take_voice(room, user)
       def toggle_voice(room, user)
         if user_has_voice?(room, user)
           take_voice(room, user)
-          return false
+          false
         else
           give_voice(room, user)
-          return true
+          true
         end
       end
 

diff --git a/locales/en.yml b/locales/en.yml
@@ -7,7 +7,7 @@ en:
         error:
           nouser: "That user was not found"
         help:
-          add:
+          voice:
             syntax: room (add|remove) @user
             desc: "Add or remove <user> to room's moderation list"
           moderate:
@@ -19,7 +19,6 @@ en:
         moderation:
           complete: Room now %{action}
         status:
-          moderated: Room is moderated
-          unmoderated: Room is unmoderated
+          overview: "Room is %{state}"
         voice:
           complete: "%{user} %{action} %{room} list"