Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return success exit code for symfony console commands #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GarciaSiego
Copy link
Contributor

No description provided.

@GarciaSiego
Copy link
Contributor Author

Having issue building on sugarcrm 12 though, so for now on my local side I have reverted to symfony 4.3 without exit codes.

When repairing sugarcrm we get a error.
PHP Fatal error: Declaration of UltraLite\Container\Container::has($serviceId) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool in /var/www/html/sugarcrm/vendor/ultra-lite/container/src/UltraLite/Container/Container.php on line 90
This is due to that symfony now expect return types. I think best to revert console to ^4.*

@esimonetti
Copy link
Owner

Hi @GarciaSiego I don't think that's the only problem.

It looks like Sugar v13 has done something different on the entryPoint.php and etc/container.php (and related files) which prevents this script from executing.

I would ask the Sugar team for input on what we should change to make this work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants