Fix issue #6

esimonov · Feb 6, 2021 · 0ee1452 · 0ee1452
1 parent f5a7f3d
commit 0ee1452
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go
@@ -135,6 +135,7 @@ func (nom namedOccurrenceMap) checkStatement(stmt ast.Stmt, ifPos token.Pos) {
 			nom.checkExpression(r, token.NoPos)
 		}
 	case *ast.SendStmt:
+		nom.checkExpression(v.Chan, token.NoPos)
 		nom.checkExpression(v.Value, token.NoPos)
 	case *ast.SwitchStmt:
 		nom.checkExpression(v.Tag, token.NoPos)
@@ -177,6 +178,7 @@ func (nom namedOccurrenceMap) checkExpression(candidate ast.Expr, ifPos token.Po
 	switch v := candidate.(type) {
 	case *ast.BinaryExpr:
 		nom.checkExpression(v.X, ifPos)
+		nom.checkExpression(v.Y, ifPos)
 	case *ast.CallExpr:
 		for _, arg := range v.Args {
 			nom.checkExpression(arg, ifPos)

diff --git a/testdata/testdata.go b/testdata/testdata.go
@@ -162,7 +162,16 @@ func notUsed_ReturnStmt_OK() interface{} {
 	return v
 }
 
-func notUsed_SendStmt_OK() {
+func notUsed_SendStmt_Chan_OK(v interface{}) {
+	ch := make(chan interface{})
+
+	if ch == nil {
+		return
+	}
+	ch <- v
+}
+
+func notUsed_SendStmt_Value_OK() {
 	v := getValue()
 	if v != nil {
 		noOp1(v)
@@ -472,3 +481,13 @@ func notUsed_TypeAssertion_OK() {
 		noOp2(w)
 	}
 }
+
+func notUsed_BinaryExprInAssign_OK() {
+	v1 := "v1"
+
+	_ = "v2" + v1
+
+	if false {
+		noOp1(v1)
+	}
+}