Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with aeson-1.x #10

Closed
themoritz opened this issue Feb 16, 2017 · 2 comments
Closed

Compatibility with aeson-1.x #10

themoritz opened this issue Feb 16, 2017 · 2 comments

Comments

@themoritz
Copy link
Contributor

This package is not compatible with aeson-1.x, at least because of haskell/aeson#307, which ended up in 1.0.0.0 and is now in lts-8.0.

Should the goal of this repo be to mirror the generic instances of aeson? If yes, I can try to prepare a PR.
@themoritz
Copy link
Contributor Author

Ah I just noticed there are aeson and argonaut specific options. So I guess the aeson version should be updated.

@eskimor
Copy link
Owner

eskimor commented Feb 17, 2017

Hi themoritz! If aeson changed it's default encoding format (which is pretty nasty!) then yes, we should adjust this library. If you could help out there, this would be much appreciated! Thank you!

@themoritz themoritz mentioned this issue Feb 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eskimor @themoritz