Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository Cleanup #1

Merged
merged 7 commits into from
Apr 30, 2015
Merged

Repository Cleanup #1

merged 7 commits into from
Apr 30, 2015

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Apr 29, 2015

see commit messages for more details

IDE files should not be part of a repository
... using templates from https://github.com/github/gitignore

IDE files should be ignored using a global gitignore file
These are essentially useless and the same information can be read
from using `git blame`
mgodave added a commit that referenced this pull request Apr 30, 2015
@mgodave mgodave merged commit 881a870 into esl-client:master Apr 30, 2015
@mgodave
Copy link
Contributor

mgodave commented Apr 30, 2015

Do you plan on working on this project more going forward? I am happy to add you as a collaborator and help with code reviews if that's something you'd be interested in.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Apr 30, 2015

@mgodave thanks for the fast reply. I have some more cleanup commits on my master branch and a few other things:

  • raised Java language level to 1.7
  • replaced Maven with Gradle

I thought that this fork was more or less dead, otherwise I would have put that stuff on feature branches. I'd appreciated if you could have a look and give me some feedback.

I also have another branch in my repo that uses http://sourceforge.net/projects/streamsupport/ to replace the SettableFuture from Guava with a backported CompletableFuture, which seems to work quite well.

@mgodave
Copy link
Contributor

mgodave commented May 3, 2015

I'm happy to take what you have in master as a PR and go from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants