Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MongooseICE compatible with WebRTC #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

rslota
Copy link
Contributor

@rslota rslota commented Aug 12, 2019

  • 0.0.0.0 IPv4 addr is now used as bind addr for relay socket. Ideally this should be configurable, but it cannot be the same as MONGOOSEICE_UDP_RELAY_IP which was used till now, as IP address of the network interface normally will be different then the actual public IP address that needs to be sent to ICE clients as "relay address". Right now, to just make it work, we'll use wildcard for binding, as this may lead to issues only when setting up multiple MongooseICE instances on one host with multiple network interfaces. When someone actually will need to cover this case, we'll need to simply add another configuration option.
  • All responses contain message-integrity attribute if possible. Whenever request is authorized, response will also be properly signed - this is apparently required by most ICE clients.
  • Use Distillery 2.1. This fixes only some annoyances while building test releases. Dockerfile has been re-written from scratch to get rid of deprecated mix_docker.

@rslota rslota changed the title [WIP] Use 0.0.0.0 as bind addr for relay socket Make MongooseICE compatible with WebRTC Aug 13, 2019
@coveralls
Copy link

coveralls commented Sep 2, 2019

Coverage Status

Coverage decreased (-0.6%) to 89.896% when pulling 5369c28 on fix-relay-bind into 358ba70 on master.

@rslota rslota requested a review from aleklisi September 2, 2019 14:31
@Neustradamus
Copy link

@rslota: Any news about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants