Use binaries in ODBC #127
Merged
Use binaries in ODBC #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the body of the functions ejabberd_odbc:escape/1 and ejabberd_odbc:escape_like/1 into odbc_queries.
| @@ -0,0 +1,8 @@ | |||
| %% Generated by the Erlang ASN.1 compiler version:1.8 | |||
There was a problem hiding this comment.
We shouldn't have the XmppAddr.hrl in the repo as it is generated automatically.
Rewrote asciz/1 using standard library functions. Send a query as an iolist into a socket. Replaced strings with binaries. Made bxor_binary/2 shorter.
|
I rebased this branch deleting XmppAddr.hrl. |
ppikula
pushed a commit
that referenced
this pull request
Sep 11, 2015
This test sometimes fails, see the #127 issue in esl/ejabberd_tests. I found that the pid in assertion doesn't match. Propably some other tests leave large_heap and MiM generates 2 alarms in random order. So I increased threshold from 100KB to 10MB to make sure, that only our designated process triggers the alarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes suggested in #122