Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New logic of packages building #2626

Merged
merged 12 commits into from
Feb 11, 2020
Merged

New logic of packages building #2626

merged 12 commits into from
Feb 11, 2020

Conversation

sebb7
Copy link
Contributor

@sebb7 sebb7 commented Feb 10, 2020

This PR changes logic of building packages.

Now packages are built for the MongooseIM version which is currently checked out on the CI job. Erlang version is also configurable and can be passed as a parameter.

@sebb7 sebb7 force-pushed the new-logic-of-packages-building branch from 2d545e9 to 2684268 Compare February 10, 2020 15:37
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 10, 2020 •
edited
Loading

7911.1 / Erlang 22.0 / small_tests / 50440ff
Reports root / small

7911.2 / Erlang 22.0 / internal_mnesia / 50440ff
Reports root/ big
OK: 1378 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0

7911.4 / Erlang 22.0 / mysql_redis / 50440ff
Reports root/ big
OK: 2608 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0

7911.3 / Erlang 22.0 / odbc_mssql_mnesia / 50440ff
Reports root/ big
OK: 2613 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

7911.5 / Erlang 22.0 / riak_mnesia / 50440ff
Reports root/ big
OK: 1511 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0

7911.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 50440ff
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7911.6 / Erlang 22.0 / ldap_mnesia / 50440ff
Reports root/ big
OK: 1343 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0

7911.9 / Erlang 21.3 / pgsql_mnesia / 50440ff
Reports root/ big / small
OK: 2626 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 10, 2020 •
edited
Loading

7912.1 / Erlang 22.0 / small_tests / 6a9087a
Reports root / small

7912.2 / Erlang 22.0 / internal_mnesia / 6a9087a
Reports root/ big
OK: 1378 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0

7912.4 / Erlang 22.0 / mysql_redis / 6a9087a
Reports root/ big
OK: 2608 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0

7912.3 / Erlang 22.0 / odbc_mssql_mnesia / 6a9087a
Reports root/ big
OK: 2613 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

7912.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 6a9087a
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7912.5 / Erlang 22.0 / riak_mnesia / 6a9087a
Reports root/ big
OK: 1511 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0

7912.6 / Erlang 22.0 / ldap_mnesia / 6a9087a
Reports root/ big
OK: 1343 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0

7912.9 / Erlang 21.3 / pgsql_mnesia / 6a9087a
Reports root/ big / small
OK: 2626 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #2626 into master will increase coverage by 1.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2626      +/-   ##
==========================================
+ Coverage   74.57%   76.28%   +1.71%     
==========================================
  Files         355      355              
  Lines       30046    30046              
==========================================
+ Hits        22406    22920     +514     
+ Misses       7640     7126     -514
Impacted Files Coverage Δ
src/mod_auth_token_rdbms.erl 0.00% <0.00%> (-100.00%) ⬇️
src/inbox/mod_inbox_rdbms_pgsql.erl 0.00% <0.00%> (-100.00%) ⬇️
src/sasl/cyrsasl_oauth.erl 14.28% <0.00%> (-85.72%) ⬇️
src/rdbms/mongoose_rdbms_pgsql_codec_boolean.erl 0.00% <0.00%> (-77.78%) ⬇️
src/rdbms/mongoose_rdbms_pgsql.erl 32.35% <0.00%> (-61.77%) ⬇️
src/mod_auth_token.erl 62.58% <0.00%> (-21.59%) ⬇️
src/rdbms/mongoose_rdbms.erl 63.77% <0.00%> (-4.09%) ⬇️
src/rdbms/rdbms_queries.erl 67.48% <0.00%> (-3.45%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 79.14% <0.00%> (-2.46%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 75.51% <0.00%> (-2.05%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d3171...326305a. Read the comment docs.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 10, 2020 •
edited
Loading

7913.1 / Erlang 22.0 / small_tests / 2e30d36
Reports root / small

7913.2 / Erlang 22.0 / internal_mnesia / 2e30d36
Reports root/ big
OK: 1378 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0

7913.4 / Erlang 22.0 / mysql_redis / 2e30d36
Reports root/ big
OK: 2608 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0

7913.3 / Erlang 22.0 / odbc_mssql_mnesia / 2e30d36
Reports root/ big
OK: 2613 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

7913.5 / Erlang 22.0 / riak_mnesia / 2e30d36
Reports root/ big
OK: 1511 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0

7913.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 2e30d36
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7913.6 / Erlang 22.0 / ldap_mnesia / 2e30d36
Reports root/ big
OK: 1343 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0

7913.9 / Erlang 21.3 / pgsql_mnesia / 2e30d36
Reports root/ big / small
OK: 2626 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

michalwski
michalwski approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. This looks good to me.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 10, 2020 •
edited
Loading

7915.1 / Erlang 22.0 / small_tests / 6992c66
Reports root / small

7915.4 / Erlang 22.0 / mysql_redis / 6992c66
Reports root/ big
OK: 2608 / Failed: 0 / User-skipped: 205 / Auto-skipped: 0

7915.2 / Erlang 22.0 / internal_mnesia / 6992c66
Reports root/ big
OK: 1378 / Failed: 0 / User-skipped: 155 / Auto-skipped: 0

7915.3 / Erlang 22.0 / odbc_mssql_mnesia / 6992c66
Reports root/ big
OK: 2613 / Failed: 0 / User-skipped: 200 / Auto-skipped: 0

7915.7 / Erlang 22.0 / elasticsearch_and_cassandra_mnesia / 6992c66
Reports root/ big
OK: 328 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0

7915.5 / Erlang 22.0 / riak_mnesia / 6992c66
Reports root/ big
OK: 1511 / Failed: 0 / User-skipped: 162 / Auto-skipped: 0

7915.6 / Erlang 22.0 / ldap_mnesia / 6992c66
Reports root/ big
OK: 1343 / Failed: 0 / User-skipped: 190 / Auto-skipped: 0

7915.9 / Erlang 21.3 / pgsql_mnesia / 6992c66
Reports root/ big / small
OK: 2626 / Failed: 0 / User-skipped: 187 / Auto-skipped: 0

@michalwski michalwski merged commit e593c9b into master Feb 11, 2020
@michalwski michalwski deleted the new-logic-of-packages-building branch February 11, 2020 08:25
@michalwski michalwski added this to the 3.6.1 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalwski michalwski michalwski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sebb7 @mongoose-im @michalwski @erszcz