TOML config #2929

chrzaszcz · 2020-11-05T07:02:36Z

Feature branch PR, includes all changes related to supporting only the TOML config format:

Drop support for the cfg format.
Make the config specs declarative.
Make services and modules specify their own config spec in their own modules.
Document the migration.

Compare the parsed TOML options directly with the expected values. The files with the expected values were generated from the 'cfg' config files. The parsed TOML options are saved after the test for easier comparison with the expected values.

1. Remove the 'split_config' case as including is not supported in TOML - It is easier to merge config files with TOML, so this feature is most likely not required anymore (unless new demand arises). 2. Remove tests for 'node_specific_options' - This is not supported in TOML. - It is not clear if something is going to be implemented instead, any future work will be done as a part of the config reloading rework (or dropping it altogether). 3. Update example config files to TOML, simplify when possible

- Convert the files to TOML, simplify when possible.

This test suite checks the 'mod_cowboy' handler for the HTTP listener. It is NOT supported in the new TOML configuration format. There is a need for a final decision here: 1. Either drop this functionality entirely (and remove the code) 2. Or implement the TOML support for it (and keep the code) The changes in this commit are reduced to minimum: the reload test is removed with the config files that are impossible to convert to TOML.

This test suite checks the functionality of mod_revproxy, which requires the 'mod_cowboy' handler for the HTTP listener. It is NOT supported in the new TOML configuration format. Similarly to 'mod_cowboy', this code should be either removed or the missing TOML support should be added. As there is no final decision yet (and to keep the steps small), the changes in this commit are reduced to minimum: the reload test is removed with the config files that are impossible to convert to TOML.

1. Use the expected options directly 2. Remove the test for 'required_files' This functionality is replaced by validators in TOML. 3. Remove the test for macros There are no macros in TOML.

Remove the equivalence test, as there are small tests for all options.

Remove the 'cfg' config format

mongoose-im · 2020-11-05T07:16:36Z

8700.1 / Erlang 23.0.3 / small_tests / b58413d
Reports root / small

8700.2 / Erlang 23.0.3 / internal_mnesia / b58413d
Reports root/ big
OK: 1493 / Failed: 1 / User-skipped: 165 / Auto-skipped: 0

:error_in_suite

{error,'config_format_SUITE cannot be compiled or loaded'}

TOML config #2929

TOML config #2929

Conversation

chrzaszcz commented Nov 5, 2020 • edited

mongoose-im commented Nov 5, 2020 • edited

mongoose-im commented Nov 5, 2020 • edited

codecov bot commented Nov 5, 2020 • edited

Codecov Report

mongoose-im commented Nov 10, 2020 • edited

mongoose-im commented Nov 17, 2020 • edited

mongoose-im commented Dec 22, 2020 • edited

mongoose-im commented Dec 22, 2020 • edited

mongoose-im commented Jan 7, 2021 • edited

mongoose-im commented Jan 8, 2021 • edited

mongoose-im commented Jan 13, 2021 • edited

mongoose-im commented Jan 15, 2021 • edited

mongoose-im commented Jan 18, 2021 • edited

leszke left a comment

Choose a reason for hiding this comment

chrzaszcz commented Nov 5, 2020 •

edited

mongoose-im commented Nov 5, 2020 •

edited

mongoose-im commented Nov 5, 2020 •

edited

codecov bot commented Nov 5, 2020 •

edited

mongoose-im commented Nov 10, 2020 •

edited

mongoose-im commented Nov 17, 2020 •

edited

mongoose-im commented Dec 22, 2020 •

edited

mongoose-im commented Dec 22, 2020 •

edited

mongoose-im commented Jan 7, 2021 •

edited

mongoose-im commented Jan 8, 2021 •

edited

mongoose-im commented Jan 13, 2021 •

edited

mongoose-im commented Jan 15, 2021 •

edited

mongoose-im commented Jan 18, 2021 •

edited