Locked MUC room disco#info

[janciesla8818]

This PR addresses the situation when a locked MUC room (locked on creation) receives disco#info.

• Previously the room responded with error The room is locked.
• With this PR when the owner of the locked room sends disco#info it is receiving supported features.
• This PR aims to help with corner case situation from XMPP compliance tests.

[mongoose-im]

8772.1 / Erlang 23.0.3 / small_tests / 4658d6a
Reports root / small

---

8772.2 / Erlang 23.0.3 / internal_mnesia / 4658d6a
Reports root/ big
OK: 1495 / Failed: 0 / User-skipped: 168 / Auto-skipped: 0

---

8772.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 4658d6a
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

---

8772.4 / Erlang 23.0.3 / mysql_redis / 4658d6a
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0

---

8772.6 / Erlang 23.0.3 / ldap_mnesia / 4658d6a
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0

---

8772.5 / Erlang 23.0.3 / riak_mnesia / 4658d6a
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0

---

8772.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 4658d6a
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

---

8772.9 / Erlang 22.3 / pgsql_mnesia / 4658d6a
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

[codecov]

Codecov Report

Merging #2956 (577829e) into master (39fafdf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2956      +/-   ##
==========================================
- Coverage   79.12%   79.11%   -0.02%     
==========================================
  Files         377      377              
  Lines       32839    32839              
==========================================
- Hits        25985    25979       -6     
- Misses       6854     6860       +6     

Impacted Files	Coverage Δ
src/mod_muc_room.erl	77.37% <100.00%> (-0.24%)	⬇️
src/mam/mod_mam_rdbms_prefs.erl	90.99% <0.00%> (-3.61%)	⬇️
src/rdbms/mongoose_rdbms.erl	65.40% <0.00%> (-1.90%)	⬇️
src/muc_light/mod_muc_light.erl	82.19% <0.00%> (-0.92%)	⬇️
src/mam/mod_mam_utils.erl	88.99% <0.00%> (-0.65%)	⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl	76.83% <0.00%> (-0.57%)	⬇️
src/mod_muc_log.erl	77.29% <0.00%> (ø)
src/ejabberd_s2s_out.erl	58.12% <0.00%> (+0.22%)	⬆️
src/ejabberd_sm.erl	75.98% <0.00%> (+0.30%)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fafdf...577829e. Read the comment docs.

[NelsonVides]

Changes are perfect, code is neat and well done. Changes make sense. But the XEP is not really clear on that, it basically only says that the owner is a member of the room from the very beginning, even before it is configured and other users are allowed to find it and enter it. I guess it's implicit then that the owner can query the room 🤷‍♂️