Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Reference about store_groupchat_messages option in mod_offline added #2992

Merged

Conversation

antivista
Copy link

@antivista antivista commented Jan 2, 2021

This PR adds documentation for mod_offline, regarding the option store_groupchat_messages. #2879

@DenysGonchar DenysGonchar self-requested a review January 2, 2021 14:03
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. historically there are several reasons why store_groupchat_messages option is not documented:

  1. XEP-0160 doesn't specify this functionality, because the classic MUC even doesn't send the messages to offline users.
  2. As this will not work as expected with the classic MUC, the option makes sense only with MUC-light.
  3. XEP-0160 is not recommended way of storing offline messages (especially group-chat messages), better use message archive with MUC storage enabled.

So this option is rather confusing than brings any benefit, it's kept for compatibility reasons.

So let's either keep it not documented or fully document it.

@antivista
Copy link
Author

antivista commented Jan 2, 2021

Although the use of mod_mam is the better approach in most of the cases, client side requires more effort (compared with XEP-0160) to implement XEP-0313, so I have thought that to document this option could be good in these scenarios:

  • As a momentary alternative waiting the XEP-0313 implementation client side;
  • If it is expected the use of just one client per user and when a message is delivered (for some reason) we do not want allow the rescue of that message again, to do this with mod_mam should require more work because XEP-0313 does not foresee a mechanism of message deletion except for the older messages in the archive.

If these scenarios are considered of interest, I can try to fully document, referring to explicitly to MUC-light case as DenysGonchar rightly pointed out to me.

Copy link
Author

@antivista antivista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that it is adequately documented now.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 👍🏽

Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for your contribution

@DenysGonchar DenysGonchar merged commit f01f80b into esl:master Mar 17, 2021
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants