Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less stringprepping in privacy modules #3005

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

NelsonVides
Copy link
Collaborator

A few less stringprepps in another module that comes up on every once in a while, like on opening sessions, when the privacy lists is queried the first time (then it's cached) for a message delivery, or when the privacy list is modified and then broadcasted.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 12, 2021

9011.1 / Erlang 23.0.3 / small_tests / 90f73e7
Reports root / small


9011.2 / Erlang 23.0.3 / internal_mnesia / 90f73e7
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 160 / Auto-skipped: 0


9011.4 / Erlang 23.0.3 / mysql_redis / 90f73e7
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 233 / Auto-skipped: 0


9011.3 / Erlang 23.0.3 / odbc_mssql_mnesia / 90f73e7
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


9011.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / 90f73e7
Reports root/ big
OK: 330 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9011.5 / Erlang 23.0.3 / riak_mnesia / 90f73e7
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 180 / Auto-skipped: 0


9011.6 / Erlang 23.0.3 / ldap_mnesia / 90f73e7
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 258 / Auto-skipped: 0


9011.9 / Erlang 22.3 / pgsql_mnesia / 90f73e7
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #3005 (5cbd211) into master (20d587c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3005   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files         377      377           
  Lines       32835    32829    -6     
=======================================
- Hits        25967    25964    -3     
+ Misses       6868     6865    -3     
Impacted Files Coverage Δ
src/metrics/mongoose_metrics_hooks.erl 97.05% <ø> (ø)
src/mongoose_hooks.erl 92.24% <ø> (ø)
src/ejabberd_c2s.erl 89.33% <100.00%> (+0.22%) ⬆️
src/ejabberd_sm.erl 75.76% <100.00%> (+0.15%) ⬆️
src/mod_last.erl 88.70% <100.00%> (-0.18%) ⬇️
src/mod_privacy.erl 86.61% <100.00%> (-0.17%) ⬇️
src/mongoose_privacy.erl 93.33% <100.00%> (ø)
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-1.84%) ⬇️
src/mod_bosh_socket.erl 78.88% <0.00%> (-0.32%) ⬇️
src/mod_muc_room.erl 77.54% <0.00%> (-0.06%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d587c...5cbd211. Read the comment docs.

Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit 7f60757 into master Jan 14, 2021
@arcusfelis arcusfelis deleted the less_stringprepping_in_privacy branch January 14, 2021 11:19
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants