Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integer_to_binary/2 is available since OTP17 #3008

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

NelsonVides
Copy link
Collaborator

And list_to_integer or binary_to_integer have the same API, throwing the same errors and so on.
Also, try-of-catch is better than case catch, errors are clearer and it doesn't build a stacktrace.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 15, 2021

9020.1 / Erlang 23.0.3 / small_tests / feea90f
Reports root / small


9020.2 / Erlang 23.0.3 / internal_mnesia / feea90f
Reports root/ big
OK: 1503 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9020.3 / Erlang 23.0.3 / odbc_mssql_mnesia / feea90f
Reports root/ big
OK: 2771 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9020.4 / Erlang 23.0.3 / mysql_redis / feea90f
Reports root/ big
OK: 2766 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9020.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / feea90f
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9020.5 / Erlang 23.0.3 / riak_mnesia / feea90f
Reports root/ big
OK: 1629 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9020.6 / Erlang 23.0.3 / ldap_mnesia / feea90f
Reports root/ big
OK: 1405 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9020.9 / Erlang 22.3 / pgsql_mnesia / feea90f
Reports root/ big / small
OK: 2784 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #3008 (1c2d7e1) into master (7f60757) will decrease coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
- Coverage   79.18%   79.07%   -0.11%     
==========================================
  Files         377      377              
  Lines       32757    32757              
==========================================
- Hits        25937    25903      -34     
- Misses       6820     6854      +34     
Impacted Files Coverage Δ
src/mod_muc_room.erl 77.25% <ø> (-0.30%) ⬇️
src/offline/mod_offline.erl 78.07% <50.00%> (ø)
src/ejabberd_c2s.erl 89.33% <66.66%> (ø)
src/mam/mod_mam_utils.erl 88.99% <100.00%> (-0.65%) ⬇️
src/mod_privacy.erl 86.61% <100.00%> (ø)
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_rdbms_prefs.erl 90.99% <0.00%> (-3.61%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 75.14% <0.00%> (-2.26%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.40% <0.00%> (-1.90%) ⬇️
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-1.84%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f60757...1c2d7e1. Read the comment docs.

Copy link
Contributor

@janciesla8818 janciesla8818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes.

@janciesla8818 janciesla8818 merged commit 458fb6a into master Jan 19, 2021
@janciesla8818 janciesla8818 deleted the nv/integer_binary_conversions branch January 19, 2021 08:26
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants