Fix handover crash #3056
Merged
Fix handover crash #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue #2933. Issue summary: `p1_fsm_old` did not handle terminate with reason {handover_session} properly. What changes: added a {handover_session} as Reason to exit normally
Codecov Report
@@ Coverage Diff @@
## master #3056 +/- ##
==========================================
- Coverage 78.53% 78.43% -0.10%
==========================================
Files 378 378
Lines 31119 31120 +1
==========================================
- Hits 24440 24410 -30
- Misses 6679 6710 +31
Continue to review full report at Codecov.
|
This function was called with MRef and not the C2SPid and because of that the receive would never match. Morover the "C2SRef" name for a pid was confusing.
chrzaszcz
reviewed
Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2933.
It contains a fix to the issue as well as a related testcase.