Use prepared queries in mod_event_pusher_push #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrzaszcz
commented
Mar 22, 2021
•
chrzaszcz
commented
- Introduce prepared queries
- Update the backend API to remove an unused case that would require a separate prepared query
Codecov Report
@@ Coverage Diff @@
## master #3060 +/- ##
==========================================
+ Coverage 78.73% 78.77% +0.04%
==========================================
Files 378 378
Lines 31101 31096 -5
==========================================
+ Hits 24486 24497 +11
+ Misses 6615 6599 -16
Continue to review full report at Codecov.
|
Also: split the 'disable' callback There are two distinct use cases now: - disable/1 for cleanup on user removal - disable/3 for disabling pubsub jid with an optional node Before it was possible to specify the node without the pubsub JID. However, this was unused and there was no use case or test for it. XEP-0357 also does not allow this use case. There was no point in introducing an unused prepared query. Other changes: - Minor refactoring - Fix type specs
chrzaszcz
force-pushed
the
prepared-queries-event-pusher
branch
from
7f35e2e
to
ae33b21
Compare
big_tests/tests/push_SUITE.erl
Outdated
| %% Remove account - this should disable the notifications | ||
| escalus_connection:send(Bob, escalus_stanza:remove_account()), | ||
| escalus:assert(is_iq_result, escalus:wait_for_stanza(Bob)), | ||
| Pid = mongoose_helper:get_session_pid(Bob, distributed_helper:mim()), |
There was a problem hiding this comment.
Shouldn't we first get the session PID and only then remove the account?
DenysGonchar
requested changes
Mar 26, 2021
Also: remove an unused function.
chrzaszcz
force-pushed
the
prepared-queries-event-pusher
branch
from
bd4bd87
to
a031068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.