Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared queries for chatmarkers and smart_markers #3066

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

leszke
Copy link
Contributor

@leszke leszke commented Mar 31, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3066 (8564402) into master (8a4e707) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
- Coverage   78.76%   78.75%   -0.02%     
==========================================
  Files         378      378              
  Lines       31102    31086      -16     
==========================================
- Hits        24499    24481      -18     
- Misses       6603     6605       +2     
Impacted Files Coverage Δ
src/mod_smart_markers_rdbms.erl 92.30% <100.00%> (-1.03%) ⬇️
src/offline/mod_offline_chatmarkers_rdbms.erl 100.00% <100.00%> (+2.94%) ⬆️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/pubsub/node_hometree.erl 77.77% <0.00%> (-5.56%) ⬇️
src/cassandra/mongoose_cassandra_worker.erl 70.75% <0.00%> (-2.36%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 65.09% <0.00%> (-0.95%) ⬇️
src/ejabberd_sm.erl 75.91% <0.00%> (-0.61%) ⬇️
src/mod_bosh_socket.erl 78.88% <0.00%> (-0.32%) ⬇️
src/ejabberd_c2s.erl 89.33% <0.00%> (-0.08%) ⬇️
src/mod_muc_room.erl 77.50% <0.00%> (-0.06%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4e707...8564402. Read the comment docs.

@leszke leszke force-pushed the prepared-queries-chat-smart-markers branch 2 times, most recently from 1648bcf to 32c26e7 Compare April 6, 2021 13:37
@leszke leszke force-pushed the prepared-queries-chat-smart-markers branch from 32c26e7 to 64b2654 Compare April 7, 2021 11:35
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I only have a few minor comments.

src/mod_smart_markers_rdbms.erl Outdated Show resolved Hide resolved
src/mod_smart_markers_rdbms.erl Outdated Show resolved Hide resolved
src/offline/mod_offline_chatmarkers_rdbms.erl Outdated Show resolved Hide resolved
src/offline/mod_offline_chatmarkers_rdbms.erl Outdated Show resolved Hide resolved
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chrzaszcz chrzaszcz merged commit a9e73b8 into master Apr 7, 2021
@chrzaszcz chrzaszcz deleted the prepared-queries-chat-smart-markers branch April 7, 2021 14:11
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants