Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify checks for chat markers #3080

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Unify checks for chat markers #3080

merged 1 commit into from
Apr 13, 2021

Conversation

NelsonVides
Copy link
Collaborator

Currently checking if a stanza contains a chat markers is triplicated in
three different modules. Implement all of it in mod_smart_markers and
make the other two places simply call this one.

Currently checking if a stanza contains a chat markers is triplicated in
three different modules. Implement all of it in a new helper module and
make the other two places simply call this one.
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for moving it in a separate helper module

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #3080 (f99a331) into master (fad3ff7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   78.82%   78.84%   +0.02%     
==========================================
  Files         379      380       +1     
  Lines       31234    31227       -7     
==========================================
+ Hits        24620    24622       +2     
+ Misses       6614     6605       -9     
Impacted Files Coverage Δ
src/inbox/mod_inbox_utils.erl 92.85% <100.00%> (-0.39%) ⬇️
src/mam/mod_mam_utils.erl 89.56% <100.00%> (-0.14%) ⬇️
src/mod_smart_markers.erl 89.58% <100.00%> (+0.29%) ⬆️
src/mongoose_chat_markers.erl 100.00% <100.00%> (ø)
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/global_distrib/mod_global_distrib_utils.erl 65.09% <0.00%> (-0.95%) ⬇️
src/ejabberd_s2s_out.erl 57.89% <0.00%> (-0.23%) ⬇️
src/mod_muc_room.erl 77.50% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad3ff7...f99a331. Read the comment docs.

@DenysGonchar DenysGonchar merged commit f166757 into master Apr 13, 2021
@DenysGonchar DenysGonchar deleted the unify_has_markers_check branch April 13, 2021 12:37
@leszke leszke added this to the 4.2.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants