New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test runner documentation #3087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only have one comment.
|
||
```bash | ||
# Ubuntu | ||
$ sudo apt install freetds-dev tdsodbc | ||
|
||
# CentOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that the Driver
and Setup
variables (mentioned in the following lines) are set correctly for Ubuntu/macOS in the scripts. I was considering removing CentOS mentions altogether. But as you pointed out, I think there is no reason for removing this, I will revert this change.
Typos, commas, language fixes, etc.
aa6f864
to
73b0d8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3087 +/- ##
==========================================
- Coverage 78.84% 78.83% -0.01%
==========================================
Files 377 377
Lines 31259 31259
==========================================
- Hits 24645 24644 -1
- Misses 6614 6615 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR updates the documentation of test runner. The main changes include correct examples (using existing presets) and rewording the ODBC parts in the documentation. It also includes fixes for small issues I noticed while reading the docs.