Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test runner documentation #3087

Merged
merged 4 commits into from Apr 19, 2021
Merged

Update test runner documentation #3087

merged 4 commits into from Apr 19, 2021

Conversation

gustawlippa
Copy link
Contributor

This PR updates the documentation of test runner. The main changes include correct examples (using existing presets) and rewording the ODBC parts in the documentation. It also includes fixes for small issues I noticed while reading the docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have one comment.


```bash
# Ubuntu
$ sudo apt install freetds-dev tdsodbc

# CentOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that the Driver and Setup variables (mentioned in the following lines) are set correctly for Ubuntu/macOS in the scripts. I was considering removing CentOS mentions altogether. But as you pointed out, I think there is no reason for removing this, I will revert this change.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #3087 (aa6f864) into master (8cfa47c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head aa6f864 differs from pull request most recent head 73b0d8d. Consider uploading reports for the commit 73b0d8d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3087      +/-   ##
==========================================
- Coverage   78.84%   78.83%   -0.01%     
==========================================
  Files         377      377              
  Lines       31259    31259              
==========================================
- Hits        24645    24644       -1     
- Misses       6614     6615       +1     
Impacted Files Coverage Δ
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 71.69% <0.00%> (-1.89%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/ejabberd_sm.erl 75.60% <0.00%> (-0.31%) ⬇️
src/mod_muc_room.erl 77.33% <0.00%> (-0.18%) ⬇️
src/ejabberd_c2s.erl 89.33% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/ejabberd_s2s_out.erl 59.72% <0.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfa47c...73b0d8d. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chrzaszcz chrzaszcz merged commit 40fd1ae into master Apr 19, 2021
@chrzaszcz chrzaszcz deleted the doc/update-test-runner branch April 19, 2021 14:59
leszke added a commit that referenced this pull request Apr 19, 2021
@leszke leszke added this to the 4.2.0 milestone Apr 19, 2021
leszke added a commit that referenced this pull request Apr 19, 2021
leszke added a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants