Handle remove_domain in mod_inbox #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move host_type type into mongooseim module
Codecov Report
@@ Coverage Diff @@
## master #3103 +/- ##
==========================================
- Coverage 79.06% 79.04% -0.02%
==========================================
Files 386 386
Lines 31830 31836 +6
==========================================
Hits 25165 25165
- Misses 6665 6671 +6
Continue to review full report at Codecov.
|
| @@ -108,6 +108,30 @@ The command can be used instead: | |||
| And `mam` is used to run `mam_SUITE` suite only. | |||
|
|
|||
|
|
|||
| ## Debugging big tests database | |||
There was a problem hiding this comment.
absolutely love it.
it's needed probably twice a year but always time consuming to recall how to do it. thanks a lot
src/inbox/mod_inbox.erl
Outdated
| @@ -267,6 +271,12 @@ remove_user(Acc, User, Server) -> | |||
| mod_inbox_utils:clear_inbox(User, Server), | |||
| Acc. | |||
|
|
|||
| -spec remove_domain(mongoose_acc:t(), mongooseim:host_type(), jid:lserver()) -> | |||
There was a problem hiding this comment.
it's not mongoose_acc:t(), MB we need some special type to highlight that Acc is not used!
| @@ -15,6 +15,8 @@ | |||
| %%============================================================================== | |||
| -module(mongooseim). | |||
|
|
|||
| -type host_type() :: binary(). | |||
DenysGonchar
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses "tenant removal epic".
Proposed changes include: