Room EventData is map now

[arcusfelis]

This PR addresses "some tech debt".

Proposed changes include:

• room_event_data is now map (was a proplist)
• Remove room_send_packet hook

[codecov]

Codecov Report

Merging #3111 (da1db71) into master (9557370) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3111      +/-   ##
==========================================
- Coverage   79.22%   79.19%   -0.03%     
==========================================
  Files         388      388              
  Lines       31858    31846      -12     
==========================================
- Hits        25238    25220      -18     
- Misses       6620     6626       +6     

Impacted Files	Coverage Δ
src/mod_muc.erl	76.90% <ø> (ø)
src/mongoose_hooks.erl	92.90% <ø> (-0.05%)	⬇️
src/mam/mod_mam_muc.erl	73.01% <100.00%> (-0.70%)	⬇️
src/mod_muc_room.erl	77.51% <100.00%> (-0.02%)	⬇️
src/muc_light/mod_muc_light_codec_legacy.erl	91.05% <100.00%> (-0.05%)	⬇️
src/muc_light/mod_muc_light_codec_modern.erl	89.38% <100.00%> (-0.24%)	⬇️
src/ejabberd.erl	45.00% <0.00%> (-10.00%)	⬇️
..._distrib/mod_global_distrib_outgoing_conns_sup.erl	80.00% <0.00%> (-8.00%)	⬇️
src/mam/mod_mam.erl	88.03% <0.00%> (-0.96%)	⬇️
src/muc_light/mod_muc_light.erl	83.69% <0.00%> (-0.86%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9557370...da1db71. Read the comment docs.

[NelsonVides]

Generally love this change, thanks for the quick action! Just a few minor comments 🙂

[NelsonVides]

I don't think this is the place to put these things, they should go to the proper migration file

[arcusfelis]

I am just making less work for people, who need to write a changelog for the next release.

[NelsonVides]

Looks awesome to me 🎉

[NelsonVides]

Ah, forgot, the changelog, I didn't mean to remove it, I meant to put it on a new migration file, in the doc/migrations/ dir, as we always do

[NelsonVides]

👌🏽