Metrics per host type

[gustawlippa]

This PR updates the metrics to use host types instead of hosts. There are still some places left that use host types and should be updated when the modules are updated (for example mongoose_wpool_rdbms).

Because the host type may be any string, the spaces " " are changed to underscores "_" in the metrics modules in a simple manner on every call. Because of that, when calling functions like mongoose_metrics:get_metric_value/1, which expect the metric name, one has to provide a sanitized name - this is not needed when calling the metrics API expecting host types.

There are also some small fixes, like a bugfix for a test suite that occurred seemingly only on my computer, and getting rid of the "Failing the test due failed rerun groups" message that was printed even if the tests were successful.

[codecov]

Codecov Report

Merging #3120 (25f0555) into master (5166ab3) will increase coverage by 0.01%.
The diff coverage is 96.19%.

@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
+ Coverage   79.46%   79.48%   +0.01%     
==========================================
  Files         395      395              
  Lines       32168    32189      +21     
==========================================
+ Hits        25563    25584      +21     
  Misses       6605     6605              

Impacted Files	Coverage Δ
src/ejabberd_local.erl	77.16% <ø> (-0.36%)	⬇️
src/global_distrib/mod_global_distrib_utils.erl	65.42% <0.00%> (-0.62%)	⬇️
src/metrics/mongoose_metrics_hooks.erl	95.29% <94.91%> (-1.77%)	⬇️
src/metrics/mongoose_api_metrics.erl	92.15% <100.00%> (ø)
src/metrics/mongoose_metrics.erl	96.10% <100.00%> (+0.13%)	⬆️
src/ejabberd_sm.erl	84.17% <0.00%> (-0.34%)	⬇️
src/mam/mod_mam_utils.erl	89.56% <0.00%> (-0.34%)	⬇️
src/mod_muc_room.erl	77.45% <0.00%> (-0.06%)	⬇️
src/mod_muc_log.erl	77.72% <0.00%> (ø)
src/pubsub/mod_pubsub_db_mnesia.erl	92.82% <0.00%> (+0.42%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5166ab3...25f0555. Read the comment docs.

[NelsonVides]

All seems good to me, but I'm not confident about merging this one, yet, so maybe let's see about more opinions @chrzaszcz @DenysGonchar

[chrzaszcz]

Looks good, mostly minor comments from me. Some hooks needs fixing soon as they are not converted to host types yet.

I would like to see a test suite for metrics added to dynamic_domains.spec. Would it be possible to do it now or not yet?

[arcusfelis]

=== Ended at 2021-05-31 14:05:25
=== Location: [{escalus_mongooseim,metric_type,100},
              {escalus_mongooseim,read_metric_initial_value,60},
              {lists,foldl,1263},
              {escalus_mongooseim,maybe_read_initial_metric_values,38},
              {escalus_story,story,68},
              {test_server,ts_tc,1754},
              {test_server,run_test_case_eval1,1263},
              {test_server,run_test_case_eval,1195}]
=== === Reason: no match of right hand side value []
  in function  escalus_mongooseim:metric_type/1 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 100)
  in call from escalus_mongooseim:read_metric_initial_value/2 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 60)
  in call from lists:foldl/3 (lists.erl, line 1263)
  in call from escalus_mongooseim:maybe_read_initial_metric_values/1 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 38)
  in call from escalus_story:story/4 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl, line 68)
  in call from test_server:ts_tc/3 (test_server.erl, line 1754)
  in call from test_server:run_test_case_eval1/6 (test_server.erl, line 1263)
  in call from test_server:run_test_case_eval/9 (test_server.erl, line 1195)

[DenysGonchar]

=== Ended at 2021-05-31 14:05:25
=== Location: [{escalus_mongooseim,metric_type,100},
              {escalus_mongooseim,read_metric_initial_value,60},
              {lists,foldl,1263},
              {escalus_mongooseim,maybe_read_initial_metric_values,38},
              {escalus_story,story,68},
              {test_server,ts_tc,1754},
              {test_server,run_test_case_eval1,1263},
              {test_server,run_test_case_eval,1195}]
=== === Reason: no match of right hand side value []
  in function  escalus_mongooseim:metric_type/1 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 100)
  in call from escalus_mongooseim:read_metric_initial_value/2 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 60)
  in call from lists:foldl/3 (lists.erl, line 1263)
  in call from escalus_mongooseim:maybe_read_initial_metric_values/1 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl, line 38)
  in call from escalus_story:story/4 (/Users/mikhailuvarov/erlang/esl/MongooseIM/big_tests/_build/default/lib/escalus/src/escalus_story.erl, line 68)
  in call from test_server:ts_tc/3 (test_server.erl, line 1754)
  in call from test_server:run_test_case_eval1/6 (test_server.erl, line 1263)
  in call from test_server:run_test_case_eval/9 (test_server.erl, line 1195)

are you sure that the config provided to escalus:story/3 contains host type specific metrics? I had the similar problem in mod_ping_SUITE, see changes for mongoose_metrics parameter in this PR