adding dynamic domains support to mod_ping #3136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 79.46% 79.48% +0.02%
==========================================
Files 395 395
Lines 32196 32197 +1
==========================================
+ Hits 25584 25592 +8
+ Misses 6612 6605 -7
Continue to review full report at Codecov.
|
big_tests/test.config
Outdated
| @@ -18,6 +18,7 @@ | |||
| %% so that we rein the "bag of things" approach | |||
| {hosts, [{mim, [{node, mongooseim@localhost}, | |||
| {domain, <<"localhost">>}, | |||
| {host_type, <<"localhost">>}, | |||
There was a problem hiding this comment.
This isn't necessary, see below.
There was a problem hiding this comment.
I would rather have it defined like that, not as rpc-s.
There was a problem hiding this comment.
For me it's better to have one helper that consistently reads it from mongoose_domain_core instead of defining it multiple times for multiple hosts. Anyway, as the helper is already there, let's use it consistently. This way we can change the implementation later when needed.
…:host_type/1 interface
This PR introduces dynamic domains support for mod_ping.
Service discovery doesn't work for dynamic domains (as mod_disco doesn't support it yet), but still works correctly for statically configured domains
for a local testing you can use these commands: